Repository navigation
soak: the Inspector's connect timeout scales like every other budget - #357
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4.2.1-rc.3's soak (run 39358469907) stopped 1 h 47 min in. On the Node 24 / Windows lane, the Inspector check (
scripts/inspectorClient.test.ts) found two calls on the Streamable HTTP bridge path that ended in the Inspector's ownConnection timed out after 15000 ms. That path goes Inspector → gateway → bridge → server-everything, on a loaded runner. Every other call, and every other path, matched the direct connection. The 15 s is the Inspector CLI's fixed default for a server given by URL or command (DEFAULT_CONNECT_TIMEOUT_MS).This passes
--connect-timeoutset torequestTimeout(15000), so it scales like every other budget in the tests: unchanged on an ordinary run, 56 s on the soak. I checked locally that Inspector 2.8.0 honours the flag. Against a socket that never answers,--connect-timeout 1234givesConnection timed out after 1234 ms. Only the soak script changes.