fix(monitor): Fix stale resource utilization due to refresh ordering#2452
fix(monitor): Fix stale resource utilization due to refresh ordering#2452HananAwwad wants to merge 22 commits into
Conversation
dcac7a3 to
5368d0d
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (84.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2452 +/- ##
==========================================
- Coverage 91.89% 91.85% -0.04%
==========================================
Files 55 55
Lines 5858 5879 +21
==========================================
+ Hits 5383 5400 +17
- Misses 340 344 +4
Partials 135 135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📊 Profiling reports are ready to be viewed
💻 CPU Comparison with base Kepler💾 Memory Comparison with base Kepler (Inuse)💾 Memory Comparison with base Kepler (Alloc)⬇️ Download the Profiling artifacts from the Actions Summary page 📦 Artifact name: 🔧 Or use GitHub CLI to download artifacts: gh run download 23799234875 -n profile-artifacts-2452 |
|
The fix in However, I'm not sure the reorder is necessary. Could the Also, the |
…le utilization Fixes sustainable-computing-io#2446 - Move resources.Refresh() before firstNodeRead and calculateNodePower - Add integration test using SwitchingResourceInformer to verify no snapshot lag Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Bumps the github-actions group with 3 updates: [actions/setup-go](https://github.com/actions/setup-go), [azure/setup-helm](https://github.com/azure/setup-helm) and [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `actions/setup-go` from 6.3.0 to 6.4.0 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v6.3.0...v6.4.0) Updates `azure/setup-helm` from 4 to 5 - [Release notes](https://github.com/azure/setup-helm/releases) - [Changelog](https://github.com/Azure/setup-helm/blob/main/CHANGELOG.md) - [Commits](Azure/setup-helm@v4...v5) Updates `codecov/codecov-action` from 5.5.3 to 6.0.0 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5.5.3...v6.0.0) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.4.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: azure/setup-helm dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: codecov/codecov-action dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
…uting-io#2453) This commit disables the sarif-lint rule for pinned-deps in the scorecard workflow. Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
…#2454) This commit keeps the scorecard analysis job limited to `uses` step so scorecard-action can publish the results successfully. This moves SARIF filtering and core=scanning upload into a follow-up job Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
This commit updates the stale docs in the repo Signed-off-by: vprashar2929 <vibhu.sharma2929@gmail.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Proposals start as `draft-YYYYMMDD-short-title.md` and receive an `EP-XXX` number only after approval. Prevents numbering conflicts when draft PRs are closed or superseded. Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Rename `EP_001` to `EP-001` and `EP_TEMPLATE` to `EP-TEMPLATE` for consistent naming across all EPs. Update all references in `index.md` and `AGENTS.md`. Aligns with KEP file naming conventions: https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/0000-kep-process/README.md#git-and-github-implementation Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Add `Authors`, `Reviewers`, `Approvers`, and `Editor` metadata fields to the EP template, based on KEP metadata: https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/0000-kep-process/README.md#kep-metadata Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
This commit moves the nodename fallback logic from the exporter layer to the config layer. Signed-off-by: vprashar2929 <vibhu.sharma2929@gmail.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Modified cmd/kepler/main.go to automatically deploy HWMON when RAPL is not available. This can be overriden by setting ForceEnabled to true in the experimental hwmon field in which case kepler will force HWMON power meter to be used only. Renamed experimental.hwmon.enabled to experimental.hwmon.forceEnabled for clarity. Signed-off-by: Kaiyi Liu <kaliu@redhat.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Bumps the github-actions group with 2 updates: [softprops/action-gh-release](https://github.com/softprops/action-gh-release) and [actions/stale](https://github.com/actions/stale). Updates `softprops/action-gh-release` from 2 to 3 - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@v2...v3) Updates `actions/stale` from 9 to 10 - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Bumps [github.com/moby/spdystream](https://github.com/moby/spdystream) from 0.5.0 to 0.5.1. - [Release notes](https://github.com/moby/spdystream/releases) - [Commits](moby/spdystream@v0.5.0...v0.5.1) --- updated-dependencies: - dependency-name: github.com/moby/spdystream dependency-version: 0.5.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.42.0 to 0.45.0. - [Commits](golang/crypto@v0.42.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Hanan Awwad <eng.hanan.awwad@gmail.com>
c78009b to
c8eba9b
Compare
|
I have addressed all feedback: reverted the pre-commit version bumps, reverted the firstReading reorder, and added mock coverage |
|
any updates about this pull request? |
Summary
This PR fixes a bug where energy calculations used stale resource utilization
because resources.Refresh() was called after node power calculation.
Fix
This ensures energy attribution uses current snapshot data.
Tests
Validation
Fixes #2446