Preserve Swarm secret mount settings during rotation - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
engine.NewSecretRefwhich hardcodesFile.Name,UID,GID, andMode, breaking compose long-syntax mounts and losing custom mount options after rotation.swarm.SecretReferencemount configuration and only update the secret identity (SecretID,SecretName).Description
swarm.SecretReferenceand sets onlySecretIDandSecretNameon the clone instead of building a new reference from scratch. (internal/sync/step4_apply_service_updates.go)ref.File.Name) to the source identity usingSecretNameand knownSecretIDversions with helper predicatessecretReferenceUsesManagedSecretandsecretReferenceUsesManagedSecretPath. (internal/sync/step3_process_secrets.go)updatingServiceSecretno longer carries a logicalPath; pending update maps are keyed by the originalSecretIDand hold only the newNameandID. (internal/sync/payload.go)target,uid,gid, andmodeand verify that after sync onlySecretIDandSecretNamechange while mount settings are preserved, covering both rotation to a temporary version and restore to the parent secret. (internal/sync/synchronizer_test.go)Testing
go test ./internal/sync, which passed.go test ./..., which passed across the repository.Codex Task