Conversation
9800fc8 to
1004de1
Compare
jaivial
left a comment
There was a problem hiding this comment.
PR Review: #54 — feat: export Pi model catalog
Author: @jaivial · Base: main ← jaivial:pi-model-catalog
Files: 3 changed · +168 / −3 · 1 commit(s)
Short Summary
Adds a read-only exporter that turns the shim's live model catalog into Pi's native models.json provider shape. It preserves per-model transport differences and documents a non-destructive merge into an existing Pi configuration.
Critical Issues
None.
Important Blockers
None.
Medium Blockers
None.
Non-Blocker Nits
None.
Verdict
Approve
Compilation is clean, exported IDs match the shim's advertised /v1/models set, active passthroughs/router handling are included, and duplicate model IDs are suppressed.
1004de1 to
16a7dbd
Compare
jaivial
left a comment
There was a problem hiding this comment.
PR Review: #54 — feat: export Pi model catalog
Author: @jaivial · Base: main ← jaivial:pi-model-catalog
Files: 3 changed · +143 / −3 · 1 commit(s)
Short Summary
Adds a read-only exporter for Pi's native model-provider catalog while preserving OpenAI Chat, OpenAI Responses, and Anthropic Messages routing. It documents a merge that leaves unrelated Pi providers untouched.
Critical Issues
None.
Important Blockers
None.
Medium Blockers
None.
Non-Blocker Nits
None.
Verdict
Approve
Compilation is clean and the exported unique-ID set matches the running shim's /v1/models catalog; duplicate handling, per-model API routing, token limits, input modality metadata, and documentation are all covered.
Summary
codex-shim export-picommand for Pi-native model discovery~/.pi/agent/models.jsonVerification
python3 -m compileall -q codex_shimGET /v1/models(43/43)pi --list-modelsresolves the new provider