Throwing errors - #192
Open
RCCoop wants to merge 4 commits into
Open
Throwing errors#192RCCoop wants to merge 4 commits into
RCCoop wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeking out errors from
AEXMLElement.erroralways seemed unintuitive to me, where throwing functions are the more idiomatic Swift way to handle this. So here is a pull request that removes theerrorproperty, and instead makes the places where existing errors could be created into throwing functions.This is a breaking change, of course, since it changes the call signature of the following:
AEXMLDocument.rootGetter now throwsAEXMLError.rootElementMissingif no root element exists (previously, this would return an emptyAEXMLElementwith the error stored in itserrorproperty).AEXMLElement["key"] getter now throwsAEXMLError.elementNotFound(String)` if the element with the given name is not found (previously, this would also return an empty element with an error property).Extra changes I made:
AEXMLError.elementNotFoundnow includes the key that wasn't found, so you can chain subscripts together and know which one failed, like so:Hope you like it. Thanks for creating this library!