Repository navigation
Conversation
…one height Every column had a 60px minimum, so a short band (a one-line strip, a footer note) looked taller on the canvas than in the sent email. The minimum now applies only to a column that shows no blocks, so it stays a drop target: - a bound class follows the model: no blocks, or all hidden by the condition preview. It also holds the height while a drag hovers over an empty column, where Sortable's placeholder is already in the list; - a static :has rule covers a drag out, where Sortable moves the block away before the model changes and leaves only its .sortable-fallback clone and any display:none (v-show) blocks. The v-show check moves into an isChildShown helper, so the guard in block-chrome-structure.test.ts accepts its script form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
desheikh
force-pushed
the
fix/editor-section-column-min-height
branch
from
October 6, 2026 20:50
ad33333 to
5fe0185
Compare
desheikh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every section column has a 60px minimum height on the canvas. That's useful for an empty column (it gives you somewhere to drop a block), but a column with content keeps it too. So a short band, like a one-line footer note, looks taller in the editor than in the sent email.
This keeps the 60px only for a column that shows no blocks. A column with content is as tall as its content.
The column still keeps its 60px drop target when:
Linked issues
n/a
Type of change
Affected packages
@templatical/editorChecklist
pnpm run cipasses locally (lint + typecheck + build + test)pnpm run test:e2epasses (only if this PR touches editor UI)pnpm exec changeset)Notes for reviewers
.sortable-fallbackclone and for blocks hidden withdisplay: none. It's the least pretty part; happy to simplify (for example, a smaller floor for filled columns) if you'd rather avoid it.block-chrome-structure.test.tspins the condition-filter check as written in the template. I widened its regex to accept the same check in script form.pnpm run cior e2e.🤖 Generated with Claude Code