Repository navigation
Conversation
desheikh
force-pushed
the
feat/social-icon-color
branch
from
October 7, 2026 04:10
619e4d8 to
26b7bd4
Compare
iconStyle mixed shape with how color is applied, and a one-color icon had
no place in it. SocialIconsBlock gains an optional iconTone ("brand", the
default and what an absent value means, or "dark" or "light"), and
iconStyle gains "plain", the glyph alone. The editor shows them as Style
and Color.
It's iconTone rather than iconColor because every *Color field in the
block model holds a CSS color, and the editor's palette check reads them
that way.
The colors, glyph size and PNG folder names live in @templatical/types,
shared by the editor's inline SVG, the renderer and the PNG build, which
now writes every style in every tone. Brand-colored icons keep their URLs
and bytes. The MJML importer reads a tone back from its folder, and
Topol's outlinedbw set imports as outlined in dark.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
desheikh
force-pushed
the
feat/social-icon-color
branch
from
October 7, 2026 04:41
26b7bd4 to
b140d24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Social icons always use each platform's brand color, so there's no way to get one-color icons, like dark icons in a footer or white icons on a colored band. This adds a color choice, separate from the shape, much like Mailchimp's social block.
iconStyle(the shape) gains"plain": just the glyph, no badge.iconToneis new and optional:"brand"(the default),"dark"or"light".The editor shows them as two selects, Style and Color.
Existing templates and icon URLs don't change. The existing PNGs are generated byte-for-byte as today.
Linked issues
n/a
Type of change
Affected packages
@templatical/editor@templatical/types@templatical/rendererapps/docsAlso touched:
@templatical/import-mjmland@templatical/import-topol(they read the new tone),@templatical/template-toolsandskills/templatical(regenerated schema).Checklist
pnpm run cipasses locally (lint + typecheck + build + test)pnpm run test:e2epasses (only if this PR touches editor UI)apps/docs/<page>.mdandapps/docs/de/<page>.mdif user-facingen.tsandde.tsif I added new stringspnpm exec changeset)Notes for reviewers
{style}-{tone}/{platform}.png. Anyone self-hosting icons throughsocialIconsBaseUrlneeds to copy the new folders; the changeset says so.iconTone, noticonColor, because every other*Colorfield holds a CSS color and the editor's palette check treats them that way.@templatical/types, so the editor, the renderer and the PNG build can't drift apart.outlinedbwset now imports asoutlined+dark.pnpm run cior e2e.🤖 Generated with Claude Code