Repository navigation
Fix bug in login and logout commands to honor profile and config-file flags - #77
Merged
Merged
Conversation
Comment on lines
+18
to
+19
| ConfigFilePath: c.Parent.ConfigFile, | ||
| ProfileName: c.Parent.Profile, |
Contributor
There was a problem hiding this comment.
It's not so important here because it's not a deeply nested command, but I believe this can also be gotten through cctx.RootCommand rather than c.Parent
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Narrow fix aligning OAuth persistence with existing profile flags; no new auth flows, only correct config targeting.
Overview
Cloud login and logout now read and write OAuth credentials using the same
--config-fileand--profilevalues as the rest of the CLI, viac.Parent.ConfigFileandc.Parent.ProfileonLoadClientOAuth/StoreClientOAuth.Previously those commands ignored those flags, so sessions could be stored or cleared in the wrong profile while other cloud commands used the selected profile.
Reviewed by Cursor Bugbot for commit 0dc2eb5. Bugbot is set up for automated code reviews on this repo. Configure here.