Repository navigation
Support generic protobuf models and oneofs in TypeScript - #239
Open
VegetarianOrc wants to merge 5 commits into
Open
VegetarianOrc wants to merge 5 commits into
VegetarianOrc wants to merge 5 commits into
Conversation
tconley1428
reviewed
Oct 16, 2026
| let generated_field_name = typescript_generated_field_name(&field.name); | ||
| let wire_field_name = typescript_generated_field_name(field_name); | ||
| let wire_field_expr = format!("{WIRE_VALUE_EXPR}.{wire_field_name}"); | ||
| if let Some(PlannedWireFieldBinding::VariantMembers { wire_name, members }) = |
Collaborator
There was a problem hiding this comment.
This seems proto specific
Contributor
Author
There was a problem hiding this comment.
Alright, caused a bit of a refactor, but I aligned this to remove the proto specific and to align the way it works more closely with how the python generator structures it. LMK what you think!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Payloadand single-valuePayloadscarriers, preserve generic transfer-converter signatures, and export model-only APIs.Validation
cargo validatepassed against the staged changes before committing, covering Rust, Python, TypeScript, Go, Java, .NET, generated-file consistency, and cross-language conformance.SDK follow-up
The notification sample includes a temporary, sample-only
.d.tsaugmentation because the current TypeScript SDK does not yet export notification-service protobuf models. Remove it when the SDK exports those models. Notification conversion is tested with structural wire objects; notification binary encoding remains untested until the SDK models are available.The workflow-service generated diff preserves its existing workflow/signal generic parameters on transfer-converter methods; its runtime conversion logic is unchanged.