Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
TestWorkflowEnvironment.OnWorkflow.testWorkflowEnvironmentImpl.getWorkflowDefinition.Why?
Redundant alias lookup in
OnWorkflowcould cause one workflow to resolve to another. If workflow functionAis registered as"B"and workflow functionBis registered as"C", thenOnWorkflow(A, ...)resolved to"C"instead of"B", installing the mock under the wrong name.Missing alias lookup in
getWorkflowDefinitioncaused the test environment’s lookup behavior to differ from production’sregistry.getWorkflowDefinition. Technically, production’s extra alias lookup is incorrect because it interprets registered names as aliases. Changing that behavior requires an SDK flag and is left for another PR.Checklist