Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Make heartbeat retry metrics test deterministic by adding a interceptor that waits for activity retries to complete before completing the activity. The exact retry and failure assertions have been preserved.
Supercedes #2759
Why?
Test flake
Checklist
Closes
How was this tested:
Note
Low Risk
Integration test-only change; no production SDK behavior is modified.
Overview
Makes
TestLongRunningActivityWithHBAndGrpcRetriesdeterministic by controlling when the activity finishes relative to heartbeat gRPC retries and metrics.The test stops the suite worker and dials a dedicated client with a unary interceptor on
RecordActivityTaskHeartbeatthat signals completion (including retries) on a buffered channel. A customLongRunningHeartbeatactivity sends a fixed number of heartbeats and blocks on that channel after eachRecordHeartbeat, so no further heartbeats run while a batched RPC is outstanding and the workflow cannot complete until retries and their metrics have finished. Traffic-controller failures and metric assertions are unchanged, with operation names and expected retry counts pulled into named constants (heartbeatOperation,retryCount, etc.).Reviewed by Cursor Bugbot for commit 04252b4. Bugbot is set up for automated code reviews on this repo. Configure here.