Repository navigation
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
ExecuteChildWorkflow now resolves the child execution future with the actual memo/search-attribute
encoding error instead of ChildWorkflowExecutionAlreadyStartedError. The result future already got
the right error. Still gated by SDKFlagChildWorkflowErrorExecution, so no replay impact.
Why?
Callers saw "already started" for a child that was never sent to the server.
Checklist
Closes Child workflow memo or search attribute encoding failure is reported as
ChildWorkflowExecutionAlreadyStartedErrorbyGetChildWorkflowExecution#2761How was this tested:
New unit tests (memo, search attributes, typed/untyped conflict, flag off) fail before and pass after;
go test -race ./internal/.Any docs updates needed?
No. CHANGELOG entry added under Unreleased/Fixed.
I used AI assistance for analysis and tests; I've reviewed and understand every change.