Account for dynamic workflows when setting WorkflowImplementationOptions - #3042
Open
Quinn-With-Two-Ns wants to merge 1 commit into
Open
Account for dynamic workflows when setting WorkflowImplementationOptions#3042Quinn-With-Two-Ns wants to merge 1 commit into
Quinn-With-Two-Ns wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Account for dynamic workflows when setting
WorkflowImplementationOptions.Why?
Users expect this to work.
Checklist
Closes DynamicWorkflow not taking in account WorkflowImplementationOptions #1241
How was this tested:
Note
Low Risk
Localized worker registration/replay path fix with new tests; behavior change only affects dynamic workflows that supply options at registration.
Overview
Dynamic workflow registration now keeps the
WorkflowImplementationOptionspassed at register time (implementation class or factory) and applies them when buildingSyncWorkflow, instead of looking up options by workflow type name—which never existed for untyped/dynamic workflows.getWorkflowtreats workflows whose type is not in the registered definition map as dynamic and uses the stored options (e.g.setFailWorkflowExceptionTypes). Tests cover bothregisterWorkflowImplementationTypesandregisterWorkflowImplementationFactorywith aNullPointerExceptionthat should fail the workflow.Reviewed by Cursor Bugbot for commit b05ef43. Bugbot is set up for automated code reviews on this repo. Configure here.