Skip to content

Account for dynamic workflows when setting WorkflowImplementationOptions - #3042

Open
Quinn-With-Two-Ns wants to merge 1 commit into
temporalio:mainfrom
Quinn-With-Two-Ns:SDK-603
Open

Account for dynamic workflows when setting WorkflowImplementationOptions#3042
Quinn-With-Two-Ns wants to merge 1 commit into
temporalio:mainfrom
Quinn-With-Two-Ns:SDK-603

Conversation

@Quinn-With-Two-Ns

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

What was changed

Account for dynamic workflows when setting WorkflowImplementationOptions.

Why?

Users expect this to work.

Checklist

  1. Closes DynamicWorkflow not taking in account WorkflowImplementationOptions #1241

  2. How was this tested:

  1. Any docs updates needed?

Note

Low Risk
Localized worker registration/replay path fix with new tests; behavior change only affects dynamic workflows that supply options at registration.

Overview
Dynamic workflow registration now keeps the WorkflowImplementationOptions passed at register time (implementation class or factory) and applies them when building SyncWorkflow, instead of looking up options by workflow type name—which never existed for untyped/dynamic workflows.

getWorkflow treats workflows whose type is not in the registered definition map as dynamic and uses the stored options (e.g. setFailWorkflowExceptionTypes). Tests cover both registerWorkflowImplementationTypes and registerWorkflowImplementationFactory with a NullPointerException that should fail the workflow.

Reviewed by Cursor Bugbot for commit b05ef43. Bugbot is set up for automated code reviews on this repo. Configure here.

@Quinn-With-Two-Ns
Quinn-With-Two-Ns requested a review from a team as a code owner August 27, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DynamicWorkflow not taking in account WorkflowImplementationOptions

1 participant