Add optional name-row slot to the Nexus form - #3969
Open
KATIETOLER wants to merge 14 commits into
Open
KATIETOLER wants to merge 14 commits into
KATIETOLER wants to merge 14 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… slot Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… slot is passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and 2/3 split. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
Cloud's Create Nexus Endpoint page needs a Project dropdown on the same row as Endpoint Name. This adds optional props to
NexusForm, passed through byNexusCreateEndpoint.nameLeadingrenders a snippet beside the name input. The row splits 1/3 and 2/3 fromsmup, with a/separator to show hierarchy. The fields stack on mobile.fieldsInertlocks every field except the snippet and disables Create. Cancel stays usable. Cloud uses it until a project is picked.classmerges with the form's default layout classes. Cloud uses it to overridexl:w-1/2and cap the form width.cardwraps the fields in a holocene Card, with the actions below it.submitDisableddisables Create and skips submission without locking any fields. Cloud uses it until a project is picked.submitButtonText(onNexusCreateEndpoint) overrides the Create button label. It defaults to "Create Nexus Endpoint".Without these props the form renders as before. OSS and the edit page are unchanged.
Screenshots (if applicable) 📸
Design Considerations
Layout and the
/separator were approved by design.Testing
How was this tested 👻
Built with
svelte-packageand loaded into cloud-ui locally. Checked the name row at mobile and desktop widths, and the locked state before a project is picked. The cloud-ui integration tests for the selector pass against this build.Steps for others to test:
Existing Nexus create and edit pages should look and behave the same. The new props are exercised by the dependent cloud-ui PR.