Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contract verification currently persists tuple inputs as raw ABI types, so
submit((address,uint256))is stored and hashed assubmit(tuple). Verified-contract lookup then returns the incorrect signature and selector.Share the existing recursive ABI parameter formatter between lookup and verification persistence. Add four regressions exercising verification → database signatures → lookup for functions, events, errors, nested tuples, and fixed/dynamic tuple arrays.
Validation:
pnpm checkandpnpm check:typespass. Changed files have no Biome warnings; unrelated existing warnings remain.This fixes new signature writes. Historical incorrect signature rows require a separate repair; reverification adds canonical links but does not remove previous incorrect links.