Skip to content

fix(verification): canonicalize tuple ABI signatures - #1299

Draft
skyc1e wants to merge 1 commit into
tempoxyz:mainfrom
skyc1e:codex/verify-tuple-signatures
Draft

skyc1e wants to merge 1 commit into
tempoxyz:mainfrom
skyc1e:codex/verify-tuple-signatures

Conversation

@skyc1e

@skyc1e skyc1e commented Sep 30, 2026

Copy link
Copy Markdown

Contract verification currently persists tuple inputs as raw ABI types, so submit((address,uint256)) is stored and hashed as submit(tuple). Verified-contract lookup then returns the incorrect signature and selector.

Share the existing recursive ABI parameter formatter between lookup and verification persistence. Add four regressions exercising verification → database signatures → lookup for functions, events, errors, nested tuples, and fixed/dynamic tuple arrays.

Validation:

  • All 260 contract-verification tests pass, including four regressions observed failing before the fix. The local Cloudflare test pool disables outbound requests and remote bindings; the new regressions inject compiler/RPC responses.
  • Root pnpm check and pnpm check:types pass. Changed files have no Biome warnings; unrelated existing warnings remain.
  • All six configured pre-commit checks pass through equivalent repo-local builtin/system execution. The original hook installer was not run because it would install Python/Go environments.

This fixes new signature writes. Historical incorrect signature rows require a separate repair; reverification adds canonical links but does not remove previous incorrect links.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant