Skip to content

feat(explorer): remove individual recent searches - #1301

Open
0xKitsune wants to merge 1 commit into
mainfrom
factory/explorer-remove-recent
Open

0xKitsune wants to merge 1 commit into
mainfrom
factory/explorer-remove-recent

Conversation

@0xKitsune

@0xKitsune 0xKitsune commented Oct 1, 2026 •

Copy link
Copy Markdown

This PR adds a remove button to each recent explorer search so users can discard one entry without clearing their history.

Mental model

Removal uses the existing canonical identity, preserves the remaining order, and reuses best-effort localStorage persistence:

const key = getSearchResultKey(target)
return results.filter((item) => getSearchResultKey(item) !== key)

The input regains focus before the removed button unmounts. Recent history uses an accessible grid with separate activate/remove buttons; normal search suggestions retain their listbox. Search routing, Clear, the six-entry limit, validation, and storage format remain unchanged. Storage write failures leave the current UI usable; cross-tab synchronization is unchanged.

Testing

  • 205 explorer worker tests and 301 Node tests passed (14 new); one existing test skipped.
  • Root format/type checks, test types, Tempo lint, explorer build, and precommit passed.
  • Real desktop/mobile Chrome: individual removal, reload persistence, keyboard Tab/Space/Enter, focus after last deletion, re-add, Clear, and injected storage-write failure.

Screenshots

Before After
Before After

Independent verification and run log pass for this candidate. Current-head required CI and Bundle Size pass for feb1fe8d; preview jobs are skipped by the existing organization-membership guard. Cyclops completed and published no actionable findings, but its archived review completeness is blocked: 1 ruled-out conclusion lacks current-revision exact-read support. Diagnosis and evidence. One of three Cyclops submissions has been used. Local verification and four-feature composition pass, but this PR is not factory-ready. Nothing has been merged or deployed.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Bundle Size Report

Metric Size Δ Change
Total 17.4 MB +13.1 MB (+309.9%)
Gzip 3.9 MB +2.7 MB (+219.9%)
Brotli 3.3 MB +2.2 MB (+209.7%)
Chunk changes (>1KB)
Chunk Change
assets/chains.js (removed) -360.7 KB
assets/tempo-queries.js -301.0 KB
assets/core.js (removed) -189.5 KB
assets/export-rate-limit.js (removed) -177.3 KB
assets/engine-javascript.js (removed) -92.9 KB
assets/decodeAbiParameters.js (removed) -71.7 KB
assets/_hash.js -36.1 KB
assets/react.js -31.8 KB
assets/AbiItem.js (removed) -27.1 KB
assets/sha2.js (removed) -14.7 KB
assets/queryOptions.js -11.8 KB
assets/Bytes.js -9.6 KB
assets/Amount.js -9.6 KB
assets/env.js -9.2 KB
assets/fee-amm-pool-rows.js (removed) -6.6 KB
assets/DataGrid.js -5.8 KB
assets/validators.js (removed) -5.1 KB
assets/token.js -5.0 KB
assets/tokens.js -1.1 KB
assets/Value.js (removed) -1.0 KB
...and 357 more

Compared against main branch (baseline from 4/27/2026, 4:02:54 PM)

@0xKitsune

Copy link
Copy Markdown
Author

cyclops-audit fast

@tempoxyz-bot tempoxyz-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ Cyclops Review — No actionable findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants