Repository navigation
fix(deps): Patch undici WebSocket denial of service - #156
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
sds
added a commit
that referenced
this pull request
Sep 29, 2026
CI dependency installation fails because Aegis rejects `tar@7.5.16` with `criticalCVE`, as seen in [PR #156's failed install](https://github.com/tempoxyz/wallet-cli/actions/runs/36517287127/job/109242311912). The installed version is affected by [CVE-2026-59873 / GHSA-23hp-3jrh-7fpw](GHSA-23hp-3jrh-7fpw), which permits resource exhaustion while extracting archives. Pin the transitive tar dependency to 7.5.22 and regenerate the lockfile. This version also covers the newer [GHSA-r292-9mhp-454m](GHSA-r292-9mhp-454m) fix. The dependency comes from the development-only `@yao-pkg/pkg` packager, which uses tar to extract downloaded Node.js archives. Include a non-release changelog entry for this toolchain update. This PR targets main independently of [#156](#156); merge this first, then update that PR from main. Existing security enforcement is unchanged. Validation: - Frozen-lockfile install and dependency tree check: only tar 7.5.22 resolves. - Lint, application/test type checks, TypeScript build, CLI bundle, changed-file formatting, and changelog validation passed. - Created and extracted a small gzip archive using tar resolved through the packager; content matched. - Full unit tests and standalone binary generation were not rerun. The prior unit run was limited by the sandbox's missing sqlite3 executable. The CLI bundle retains its existing import.meta/CommonJS warning. - The live Aegis-protected CI install must confirm the policy block is cleared. Prompted by: @sds Co-authored-by: Shane da Silva <677877+sds@users.noreply.github.com>
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
decofe
force-pushed
the
centaur/fix-undici-websocket-dos-1790652296
branch
from
September 29, 2026 03:44
cb89ace to
794f188
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the direct undici dependency from 8.9.0 to 8.10.2 and regenerate the lockfile. This addresses GHSA-3wwx-pv8p-q78v, a process crash caused by malformed compressed WebSocket messages, and Dependabot alerts #55 and #56.
Validation:
Prompted by: @sds