feat(cos): [000000000] support status and tags in bucket lifecycle rules - #4397
Open
tao1020 wants to merge 3 commits into
Open
feat(cos): [000000000] support status and tags in bucket lifecycle rules#4397tao1020 wants to merge 3 commits into
tao1020 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
statusandfilter_tagssupport totencentcloud_cos_bucket.lifecycle_rules, including read/flatten support for the bucket resource andtencentcloud_cos_bucketsdata source.Why
Tencent Cloud COS lifecycle rules support Enabled/Disabled status and tag filters, including prefix-plus-tags and multiple-tag AND filters. The provider previously hard-coded every rule to Enabled and exposed only
filter_prefix, so these API capabilities could not be configured or preserved in Terraform state.Type of change
Validation
env -u GOOS -u GOARCH go test ./tencentcloud/services/cos -count=1env -u GOOS -u GOARCH go test -v ./tencentcloud -run TestProvider -count=1env -u GOOS -u GOARCH make buildenv -u GOOS -u GOARCH make check-muxgo.modchangesmake lintunavailable locally becausegolangci-lintis not installedmake testis blocked by unrelated existing failures ingendoc,common,bh,cam, andcbs; the changed COS package passesNotes for reviewers
statusdefaults toEnabled, matching the previous hard-coded behavior.Filter.Tag; multiple tags or prefix-plus-tags useFilter.And. Tags are sorted for deterministic requests.filter_tagsvalidates the COS maximum of 10 tags and key/value byte limits.filter_tagswithabort_incomplete_multipart_uploadin the same lifecycle rule, as COS does not support that combination.