feat(website): embed a live OpenKara app preview#123
Draft
thedavidweng wants to merge 9 commits into
Draft
Conversation
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
thedavidweng
changed the title
thedavidweng
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=======================================
- Coverage 77.3% 77.1% -0.2%
=======================================
Files 126 126
Lines 6266 6313 +47
Branches 1984 2055 +71
=======================================
+ Hits 4846 4873 +27
- Misses 1376 1395 +19
- Partials 44 45 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The product preview should look like the real desktop app first, while avoiding accidental input that would make the landing scene unstable. The new strip is intentionally framed as a playful "Built with" list rather than a customer or partner claim.
Verification
node --run formatnode_modules/.bin/tsc --noEmit --project website/tsconfig.jsonnode --run lintnode --run test— 1,322 tests passednode --run docs:build/faq/,/privacy/,/terms/, and their/zh/equivalents.Visual QA status
The local-preview browser policy still prevents a same-viewport browser capture in this session, so this PR does not claim pixel-level visual sign-off. The implementation was checked against the supplied Linear and Feldar references in source and through the static production build.