Skip to content

enhancement: checkbox and radio components with 'disabled:cursor-not-allowed'#1212

Closed
abdulbasithqb wants to merge 4 commits intothemesberg:mainfrom
qburst:fixes/input-cursor-not-allowed
Closed

enhancement: checkbox and radio components with 'disabled:cursor-not-allowed'#1212
abdulbasithqb wants to merge 4 commits intothemesberg:mainfrom
qburst:fixes/input-cursor-not-allowed

Conversation

@abdulbasithqb
Copy link
Copy Markdown
Contributor

Enhance Checkbox and Radio Styling

Changes:

Improve styling for checkbox and radio components by adding a 'disabled' look with a non-interactive cursor.

Why:

Enhances user experience by clearly indicating the disabled state.
Prevents unintended interactions with disabled checkboxes and radio buttons.

Screenshots:

Screen.Recording.2024-01-03.at.1.09.45.PM.mov

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 4:24pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7461173) 99.54% compared to head (3692669) 97.38%.
Report is 193 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
- Coverage   99.54%   97.38%   -2.17%     
==========================================
  Files         163      216      +53     
  Lines        6621     9217    +2596     
  Branches      401      538     +137     
==========================================
+ Hits         6591     8976    +2385     
- Misses         30      241     +211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tulup-conner
Copy link
Copy Markdown
Collaborator

Personally, I agree with this decision but it's not in the main library (https://flowbite.com/docs/forms/checkbox/#disabled-state) @zoltanszogyenyi Is this something we'd be interested in universally for Flowbite?

@rluders
Copy link
Copy Markdown
Collaborator

rluders commented Jan 31, 2024

@abdulbasithqb it is important that instead of 'merge' the main with your branch, you rebase it, so it would not break the git history.

@abdulbasithqb
Copy link
Copy Markdown
Contributor Author

@abdulbasithqb it is important that instead of 'merge' the main with your branch, you rebase it, so it would not break the git history.

Hey, new PR raised PR #1255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants