Skip to content

refactor(retry): move duplicated participant-selection into a shared package #4118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mswilkison merged 2 commits into from
Jun 27, 2026
Merged

refactor(retry): move duplicated participant-selection into a shared package #4118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c04bc77
refactor(retry): move duplicated participant-selection into a shared …
mswilkison Jun 26, 2026
d902f73
Merge branch 'feat/frost-schnorr-migration-scaffold' into fix/dedup-r…
mswilkison Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
290 changes: 0 additions & 290 deletions pkg/frost/retry/retry_test.go
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion pkg/frost/roast/signing_retry_adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ type SigningRetryAdapter[T any] struct {
}

// EvaluateRetryParticipantsForSigning matches the shape of the
// legacy helper in pkg/frost/retry so call sites can adopt the
// legacy helper in pkg/protocol/retry so call sites can adopt the
// adapter without changing their function-call surface. The legacy
// signature's parameters (groupMembers, seed, retryCount,
// retryParticipantsCount) are ignored: the AttemptContext bound to
Expand Down
0 pkg/frost/retry/retry.go → pkg/protocol/retry/retry.go
View file
Open in desktop
File renamed without changes.
0 pkg/tecdsa/retry/retry_test.go → pkg/protocol/retry/retry_test.go
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion pkg/tbtc/dkg_loop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (
"github.com/ipfs/go-log/v2"
"github.com/keep-network/keep-core/pkg/chain"
"github.com/keep-network/keep-core/pkg/protocol/group"
"github.com/keep-network/keep-core/pkg/protocol/retry"
"github.com/keep-network/keep-core/pkg/tecdsa/dkg"
"github.com/keep-network/keep-core/pkg/tecdsa/retry"
"golang.org/x/exp/slices"
)

Expand Down
4 changes: 2 additions & 2 deletions pkg/tbtc/signing_loop_legacy_selector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import (
"sort"

"github.com/keep-network/keep-core/pkg/chain"
"github.com/keep-network/keep-core/pkg/frost/retry"
"github.com/keep-network/keep-core/pkg/protocol/group"
"github.com/keep-network/keep-core/pkg/protocol/retry"
)

// legacySigningParticipantSelector is the pre-RFC-21 implementation:
// it calls the pseudo-random retry shuffle in pkg/frost/retry and maps
// it calls the pseudo-random retry shuffle in pkg/protocol/retry and maps
// the resulting qualified operators back to the included member
// indices.
//
Expand Down
2 changes: 1 addition & 1 deletion pkg/tbtc/signing_loop_roast_dispatcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

// signingParticipantSelector picks the set of members included in a
// signing attempt. The legacy implementation is the pseudo-random
// retry shuffle in pkg/frost/retry; the RFC-21 Phase-6 migration
// retry shuffle in pkg/protocol/retry; the RFC-21 Phase-6 migration
// introduces this interface so an alternate ROAST-driven
// implementation can be installed behind the frost_roast_retry build
// tag without touching the call site.
Expand Down
Loading
Loading