Add keys and __contains__ method to Controls class - #88
Open
nhallez wants to merge 3 commits into
Open
Conversation
tiagocoutinho
approved these changes
Jun 8, 2026
tiagocoutinho
left a comment
Owner
There was a problem hiding this comment.
Looks good!
Thanks for the contribution
Merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Controlclass (video) inherits fromdictbut only overridesitems()andvalues(), leavingkeys()and theinkeyword to fall back to the defaultdictimplementation. This causes those methods to return an empty result immediately after device creation, before any refresh has occurred.As a result, membership checks like:
…silently fail unless
controls.refresh()is explicitly called.