Handle IPv6 endpoints in URL parser#4750
Open
officialasishkumar wants to merge 1 commit intotigera:masterfrom
Open
Handle IPv6 endpoints in URL parser#4750officialasishkumar wants to merge 1 commit intotigera:masterfrom
officialasishkumar wants to merge 1 commit intotigera:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for endpoint parsing in
pkg/url.ParseEndpoint.The parser previously split
url.Hoston every:, which rejected valid bracketed IPv6 URL endpoints such ashttps://[fd00::1]:443. This updates the parser to use the standard library host/port parser so DNS names, IPv4 hosts, and bracketed IPv6 hosts are handled consistently while malformed endpoints still fail validation.Fixes #4749
Validation run:
go test ./pkg/urlgo test ./pkg/controller/logcollector ./pkg/controller/nonclusterhost ./pkg/controller/managergo test ./pkg/rendergo test ./pkg/render/...was also attempted, butpkg/render/istiorequiresbase.tgz, which is not present in a fresh clone.Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.