src/plotting.py: properly maximize window when using matplotlib Qt backend - #28
Conversation
…ckend Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe plotting module adds a shared window-maximization helper. Fullscreen display and animation setup use it. wx managers call ChangesMatplotlib window maximization
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The backend-specific maximization update has no established new failure requiring changes before merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
I recently updated my system (to Ubuntu 26.04) and
src/plotting.py(imagewmark get -P all ...)now produces
this is because matplotlib is using Qt backend
The PR fixes this by checking if Qt's showMaximized is present and use it if it is.
Summary by CodeRabbit