fix image-stream race:#227
Merged
Merged
Conversation
After image2disk streams the cloud image to /dev/sda, the kernel and udev occasionally haven't re-read the new partition table by the time the next cexec action opens /dev/sda1, causing mount to fail with EINVAL and the workflow to fail intermittently (re-runs succeed). The race is more likely on the VirtualBox stack where the arm64 image2disk finishes in ~5s, leaving only milliseconds before grow-partition runs. A short sleep gives the partition rescan time to settle. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
added
kind/bug
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 📃 Configuration Change RequirementsWonderful, this rule succeeded.Mergify configuration change
|
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Contributor
Merge Queue Status
This pull request spent 17 seconds in the queue, including 3 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After image2disk streams the cloud image to /dev/sda, the kernel and udev occasionally haven't re-read the new partition table by the time the next cexec action opens /dev/sda1, causing mount to fail with EINVAL and the workflow to fail intermittently (re-runs succeed). The race is more likely on the VirtualBox stack where the arm64 image2disk finishes in ~5s, leaving only milliseconds before grow-partition runs. A short sleep gives the partition rescan time to settle.
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: