Skip to content

fix(frontend): tailscale prompt on every login#888

Merged
steveiliop56 merged 1 commit into
mainfrom
fix/tailscale-prompt
May 21, 2026
Merged

fix(frontend): tailscale prompt on every login#888
steveiliop56 merged 1 commit into
mainfrom
fix/tailscale-prompt

Conversation

@scottmckendry
Copy link
Copy Markdown
Member

@scottmckendry scottmckendry commented May 21, 2026

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Improved login flow handling when Tailscale device information is missing or not yet available, reducing false-negative checks and preventing unnecessary login/redirect interruptions.

Review Change Stack

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6687f6dd-0812-4cd3-a705-a42bf5dd39bd

📥 Commits

Reviewing files that changed from the base of the PR and between 0d4a133 and 82955c6.

📒 Files selected for processing (2)
  • frontend/src/pages/login-page.tsx
  • frontend/src/schemas/user-context-schema.ts

📝 Walkthrough

Walkthrough

Makes Tailscale's nodeName optional in the user context schema and updates the login page to initialize useTailscale by checking tailscale.nodeName !== undefined.

Changes

Tailscale Configuration Updates

Layer / File(s) Summary
Schema contract update
frontend/src/schemas/user-context-schema.ts
tailscaleSchema.nodeName changed from required string() to string().optional(), making tailscale.nodeName optional in the inferred user context type.
Login page state initialization
frontend/src/pages/login-page.tsx
useTailscale state initialization now uses tailscale.nodeName !== undefined instead of comparing to an empty string.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A nodeName once required, now light,
Schema whispers "optional" in the night.
Login checks for presence, not for show,
Quiet changes help the flow.
— a happy rabbit

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main fix: preventing the tailscale prompt from appearing on every login by changing nodeName validation logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tailscale-prompt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 21, 2026
@steveiliop56 steveiliop56 merged commit 8849d7e into main May 21, 2026
5 checks passed
@steveiliop56 steveiliop56 deleted the fix/tailscale-prompt branch May 21, 2026 18:02
@scottmckendry scottmckendry mentioned this pull request May 21, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants