[Budget/Notification] atomic accounting lifecycle에 threshold 알림 연결 - #68
Closed
Leejaewang03 wants to merge 1 commit into
Closed
[Budget/Notification] atomic accounting lifecycle에 threshold 알림 연결#68Leejaewang03 wants to merge 1 commit into
Leejaewang03 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
#68의 변경은 통합 PR #71에 포함되어 CI 검증을 완료했습니다. 이후 수정과 검토는 #71에서 이어갑니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
BudgetKey/BudgetWindow와 #37의 동일 linearization pointBudgetSnapshot을 그대로 사용해 threshold를 판정합니다.BudgetKey + BudgetThreshold기준 process-local dedup과 reservation transition 중복 억제를 원자적으로 처리합니다.BudgetThreshold.NONE은 발행하지 않고, HALF/WARNING/EXCEEDED 상승 단계는 window마다 한 번씩 발행합니다.BudgetNotificationErrorHook을 추가했습니다.AtomicNotificationStateStore계약을 추가했습니다.onCommittedcallback은 snapshot resolver를 통한 호환 경로를 유지하고,BudgetNotificationEvent의 legacy accessor도 유지했습니다.테스트
NotificationStateStore등록 시 명확한 자동 설정 실패전달 보장
MVP 전달은 process-local best-effort입니다. durable outbox, 재시작 후 replay, exactly-once delivery, Slack/email/webhook adapter는 포함하지 않습니다.
Closes #48