Skip to content

viewer: a pan no longer deselects on its trailing click - #630

Merged
shhdwi merged 1 commit into
trailhq:mainfrom
Rakly3:fix/viewer-pan-click-deselect
Oct 22, 2026
Merged

shhdwi merged 1 commit into
trailhq:mainfrom
Rakly3:fix/viewer-pan-click-deselect

Conversation

@Rakly3

@Rakly3 Rakly3 commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Stops panning from deselecting a node. Simple click still deselects as normal.

Local patch carried over from Y:/Coding/Graft-main (edited 2026-10-03), not upstream.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@trailhq-graft

trailhq-graft Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🌱 graft blast radius

1 area changed → 1 area can be affected. 1 dependent symbol, depth 2.
Tests: no test reaches Graph Visualization.
Tag: @anirudhkumar-nanonets — Graph Visualization, Viewer Entry Point · @shhdwi — Graph Visualization, Viewer Entry Point

flowchart TB
  A0(("Viewer Entry Point<br/>1 symbol"))
  classDef reached fill:#D9EDF3,stroke:#3AA7C9,stroke-width:1.5px,color:#0E313C;
  class A0 reached;
Loading
Can be affected Symbols Nearest hop Reached from
Viewer Entry Point 1 viewer/main.ts:L1-L323 main.ts — references, depth 1 Graph Visualization
Who knows this code — 2 people across 2 areas
Area Who knows it
Graph Visualization · changed @anirudhkumar-nanonets — 1 commit, last 2mo ago · @shhdwi — 1 commit, last 3mo ago
Viewer Entry Point · affected @anirudhkumar-nanonets — 3 commits, last 2mo ago · @shhdwi — 2 commits, last 2mo ago

Ownership is git history over each area's own files, weighted towards recent work (120-day half-life). Merge commits and bots are dropped, and you are dropped from your own PR. A name with no @ has no GitHub handle in its commit email — tag them by hand, or add a .mailmap entry. A suggestion from history, not a CODEOWNERS rule.

All 1 dependent symbol, grouped by area

Viewer Entry Point — 1 symbol in 1 file

  • viewer/main.ts:L1-L323 — main.ts (references, depth 1)
    6: import { GraphView } from "./graph.js";
Test signal per changed area — 1 ✗

Reached = a node under a test path has a resolved edge into the changed symbol. It undercounts anything called indirectly — through a CLI, a spawned process or a dynamic import — so read a low ratio as “look here”, never as a coverage gate.

  • ✗ Graph Visualization — 0 of 3 reached · no test file reaches it
    • not reached: GraphView, buildChrome, bindPanZoom

graft blast · origin/main...HEAD · depth 2 · 1 changed file

Open the interactive graph → — click an area to see its dependent symbols at file:line.

github-actions Bot added a commit that referenced this pull request Oct 16, 2026
@shhdwi

shhdwi commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Thanks! I checked this in a headless browser on both builds. On main, selecting a node and then dragging the canvas cleared the details panel. On your branch the selection survives the pan, and a plain click on empty space (even with a couple of pixels of jitter) still deselects. Merging.

@shhdwi
shhdwi merged commit 22aa846 into trailhq:main Oct 22, 2026
2 checks passed
github-actions Bot added a commit that referenced this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants