dev: base make on sources, use project-local TS#359
Open
gthb wants to merge 1 commit into
Open
Conversation
Spare newcomers like me from some stumbles :) with two Makefile improvements: 1. Default `TS` to `npx tree-sitter` instead of `tree-sitter`, to use the tree-sitter CLI version pinned in the project rather than whatever global binary happens to be on `$PATH` 2. Change the Make rule for parser generation to depend on the actual sources `grammar.js` and `../common/define-grammar.js` rather than the derived file `src/grammar.json`, so that editing a grammar source and running `make` regenerates `src/grammar.json` before regenerating the parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Makefile improvements to spare newcomers like me some stumbles :)
Default
TStonpx tree-sitterinstead oftree-sitter, to use the tree-sitter CLI version pinned in the project rather than whatever global binary happens to be on$PATH(which could result in arbitrary unrelated diffs in the generated parser)Change the Make rule for parser generation to depend on the actual sources
grammar.jsand../common/define-grammar.jsrather than the derived filesrc/grammar.json, so that editing a grammar source and runningmakeregeneratessrc/grammar.jsonbefore regenerating the parser.