[BUGFIX] pre-release workflow: replace deprecated ::set-output - #303
Closed
treee111 wants to merge 1 commit into
Closed
[BUGFIX] pre-release workflow: replace deprecated ::set-output#303treee111 wants to merge 1 commit into
treee111 wants to merge 1 commit into
Conversation
treee111
force-pushed
the
bugfix/pre-release-workflow-branch-pattern
branch
from
August 26, 2026 15:08
0a20ff8 to
46169e9
Compare
…sions
The workflow command syntax ::set-output is deprecated by GitHub. Instead of
writing to $GITHUB_OUTPUT, the whole "Set output" step is removed and
${{ github.ref_name }} is used directly. It gives the short name of the
branch or the tag and therefore works for all three release workflows -
git-release.yml is triggered by a tag, the other two by a branch.
Also bumps actions/checkout v2/v3 -> v4 and actions/setup-python v3 -> v5.
The old versions run on a deprecated node runtime.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
treee111
force-pushed
the
bugfix/pre-release-workflow-branch-pattern
branch
from
August 26, 2026 15:16
46169e9 to
c99f5a2
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR…
::set-outputworkflow command in "Create pre-release with .zip files" with$GITHUB_OUTPUT.Background
This PR started out as a fix for the workflow not triggering on
release/v4.4.0, because the branch filter isrelease-*and*does not match a/. That was the wrong direction — every previous release branch used a dash (release-v0.9.0,release-v1.1.1,release-v2.0.2,release-v4.0.0,release-v4.1.1), so the branch name was the outlier, not the workflow. The branch has been renamed torelease-v4.4.0and the trigger works again with no workflow change.What remains is the one problem in that step that has nothing to do with branch naming.
Considerations and implementations
- name: Set output id: vars - run: echo ::set-output name=tag::${GITHUB_REF#refs/*/} + run: echo "tag=${GITHUB_REF#refs/heads/}" >> "$GITHUB_OUTPUT"::set-outputis deprecated by GitHub in favour of writing to the$GITHUB_OUTPUTfile. It still works today but produces a deprecation warning and is slated for removal — at which point${{ steps.vars.outputs.tag }}would silently become empty and the .zip files would be namedwahooMapsCreator-device_themes-.zip.${GITHUB_REF#refs/heads/}replaces${GITHUB_REF#refs/*/}. This trigger is a push to a branch, so the prefix is alwaysrefs/heads/; being explicit avoids relying on*matching across path separators. Forrefs/heads/release-v4.4.0both producerelease-v4.4.0, so the resulting file names are unchanged.The
branches: ["release-*"]filter is deliberately left untouched.Out of scope, but worth a look later
actions/checkout@v2in this workflow (and ingit-release.yml/git-release-test.yml) runs on a deprecated Node runtime —@v4would be the current one.tests.ymlruns on push only fordevelop, so release branches get pylint only via pull requests.How to test
release-v4.4.0. The workflow runs and the "Set output" step no longer logs aset-outputdeprecation warning.wahooMapsCreator-device_themes-release-v4.4.0.zip— identical naming to before.Pull Request Checklist
🤖 Generated with Claude Code