Skip to content

[BUGFIX] pre-release workflow: replace deprecated ::set-output - #303

Closed
treee111 wants to merge 1 commit into
release-v4.4.0from
bugfix/pre-release-workflow-branch-pattern
Closed

[BUGFIX] pre-release workflow: replace deprecated ::set-output#303
treee111 wants to merge 1 commit into
release-v4.4.0from
bugfix/pre-release-workflow-branch-pattern

Conversation

@treee111

@treee111 treee111 commented Aug 26, 2026

Copy link
Copy Markdown
Owner

This PR…

  • Replaces the deprecated ::set-output workflow command in "Create pre-release with .zip files" with $GITHUB_OUTPUT.

Background

This PR started out as a fix for the workflow not triggering on release/v4.4.0, because the branch filter is release-* and * does not match a /. That was the wrong direction — every previous release branch used a dash (release-v0.9.0, release-v1.1.1, release-v2.0.2, release-v4.0.0, release-v4.1.1), so the branch name was the outlier, not the workflow. The branch has been renamed to release-v4.4.0 and the trigger works again with no workflow change.

What remains is the one problem in that step that has nothing to do with branch naming.

Considerations and implementations

       - name: Set output
         id: vars
-        run: echo ::set-output name=tag::${GITHUB_REF#refs/*/}
+        run: echo "tag=${GITHUB_REF#refs/heads/}" >> "$GITHUB_OUTPUT"

::set-output is deprecated by GitHub in favour of writing to the $GITHUB_OUTPUT file. It still works today but produces a deprecation warning and is slated for removal — at which point ${{ steps.vars.outputs.tag }} would silently become empty and the .zip files would be named wahooMapsCreator-device_themes-.zip.

${GITHUB_REF#refs/heads/} replaces ${GITHUB_REF#refs/*/}. This trigger is a push to a branch, so the prefix is always refs/heads/; being explicit avoids relying on * matching across path separators. For refs/heads/release-v4.4.0 both produce release-v4.4.0, so the resulting file names are unchanged.

The branches: ["release-*"] filter is deliberately left untouched.

Out of scope, but worth a look later

  • actions/checkout@v2 in this workflow (and in git-release.yml / git-release-test.yml) runs on a deprecated Node runtime — @v4 would be the current one.
  • tests.yml runs on push only for develop, so release branches get pylint only via pull requests.

How to test

  1. Push a commit to release-v4.4.0. The workflow runs and the "Set output" step no longer logs a set-output deprecation warning.
  2. The produced asset is wahooMapsCreator-device_themes-release-v4.4.0.zip — identical naming to before.

Pull Request Checklist

🤖 Generated with Claude Code

@treee111
treee111 force-pushed the bugfix/pre-release-workflow-branch-pattern branch from 0a20ff8 to 46169e9 Compare August 26, 2026 15:08
@treee111 treee111 changed the title [BUGFIX] pre-release workflow: run on release/* branches too [BUGFIX] pre-release workflow: replace deprecated ::set-output Aug 26, 2026
…sions

The workflow command syntax ::set-output is deprecated by GitHub. Instead of
writing to $GITHUB_OUTPUT, the whole "Set output" step is removed and
${{ github.ref_name }} is used directly. It gives the short name of the
branch or the tag and therefore works for all three release workflows -
git-release.yml is triggered by a tag, the other two by a branch.

Also bumps actions/checkout v2/v3 -> v4 and actions/setup-python v3 -> v5.
The old versions run on a deprecated node runtime.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@treee111
treee111 force-pushed the bugfix/pre-release-workflow-branch-pattern branch from 46169e9 to c99f5a2 Compare August 26, 2026 15:16
@treee111 treee111 closed this Aug 26, 2026
@treee111
treee111 deleted the bugfix/pre-release-workflow-branch-pattern branch August 26, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant