Feature: Support transactionalBatch;#5
Open
brettz9 wants to merge 1 commit into
Open
Conversation
Feature: Allow preexisting transaction to be supplied to `batch()` (or `transactionalBatch()`); Feature: Support `move`, `copy` operations; Testing: Fix test name/db; add 'clear' test Imports: Avoid deprecation notice for regenerator; Refactoring: Add babel-polyfill for iterators; Refactoring: Use increment/decrement operators, avoid redundant Boolean cast; Refactoring: For transaction, use `addEventListener` in place of on* handlers (may be reused, e.g., by function-type operations)
Contributor
Author
|
And any update re: reviews on this? |
| @@ -1,3 +1,5 @@ | |||
| import 'babel-polyfill' // Array.prototype.values, etc. | |||
Contributor
There was a problem hiding this comment.
this library has to be minimal, therefor no "babel-polyfill" or usage of native ES2016 features like .values or .includes
Contributor
|
Hey @brettz9, I'm not sure about merging this PR, because it has to ditch Safari 9 in order to support multiple transactions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1 and #2
Feature: Support
transactionalBatch;Feature: Allow preexisting transaction to be supplied to
batch()(ortransactionalBatch());Feature: Support
move,copyoperations;Testing: Fix test name/db; add 'clear' test
Imports: Avoid deprecation notice for regenerator;
Refactoring: Add babel-polyfill for iterators;
Refactoring: Use increment/decrement operators, avoid redundant Boolean cast;
Refactoring: For transaction, use
addEventListenerin place of on* handlers (may be reused, e.g., by function-type operations)