Skip to content

Tests package included as top level package in python wheel #876

Description

@brettmthompson

When executing the build_wheel.py script locally, i.e. python3 setup.py bdist_wheel, the tests package is included as a top level package in the generated tritonclient python wheel. In general, it is best practice to only include production code required by users to run the software.

The current packages found in the produced top_level.txt package are:

tests
tritonclient
tritonclientutils
tritongrpcclient
tritonhttpclient
tritonshmutils

It appears the wheel available on pypl does not include the tests package.

To align local builds with what is available on pypl, the tests package should be excluded from the find_packages() call in setup.py:

find_packages(exclude=['tests'])

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions