Skip to content

Fix GitHub Actions grouping rule to use matchManagers#11

Merged
bryanbeverly merged 1 commit into
mainfrom
fix-github-actions-datasource
May 28, 2026
Merged

Fix GitHub Actions grouping rule to use matchManagers#11
bryanbeverly merged 1 commit into
mainfrom
fix-github-actions-datasource

Conversation

@bryanbeverly

@bryanbeverly bryanbeverly commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Changes matchDatasources: ["github-actions"] to matchManagers: ["github-actions"] in the shared preset
  • github-actions is a Renovate manager, not a datasource. The actual datasources are github-tags, github-digest, and github-runners
  • Found by Cursor Bugbot during Step 3a PR reviews

Context

Part of the Dependency Strategy Unification plan. After merge, tag as v1.0.1.

Made with Cursor


Note

Low Risk
Config-only change to Renovate grouping; no runtime app or security logic affected.

Overview
Corrects the shared Renovate preset so the GitHub Actions grouping rule actually applies: the package rule now uses matchManagers: ["github-actions"] instead of matchDatasources, because github-actions is a Renovate manager, not a datasource.

Without this fix, the rule would not match Action updates as intended, so grouped github-actions PRs might not be produced.

Reviewed by Cursor Bugbot for commit 04d7069. Bugbot is set up for automated code reviews on this repo. Configure here.

github-actions is a manager name, not a datasource. The actual
datasources are github-tags, github-digest, and github-runners.
Using matchManagers is the correct field per Renovate docs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bryanbeverly bryanbeverly requested a review from a team May 28, 2026 21:58

@bryanbeverly bryanbeverly left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would've worked as-is, but it's technically wrong and only works because of they're letting it work... in case a new Renovate version "fixes" this, we should use the correct function.

@bryanbeverly bryanbeverly merged commit 206cca7 into main May 28, 2026
3 checks passed
@bryanbeverly bryanbeverly deleted the fix-github-actions-datasource branch May 28, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant