Skip to content

fix: publish node image with tag latest - #1194

Merged
MicBun merged 1 commit into
mainfrom
fixPublishNode
Oct 8, 2025
Merged

fix: publish node image with tag latest#1194
MicBun merged 1 commit into
mainfrom
fixPublishNode

Conversation

@MicBun

@MicBun MicBun commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

resolves: #1193

Summary by CodeRabbit

  • Chores
    • Updated the publishing workflow to treat the latest-tag input as a boolean, ensuring correct latest image tagging during manual triggers and releases.
    • Upgraded backend dependencies to newer versions for improved compatibility and alignment with upstream changes.

@MicBun
MicBun requested a review from outerlook October 8, 2025 03:01
@MicBun MicBun self-assigned this Oct 8, 2025
@MicBun MicBun added the type: fix fixing something label Oct 8, 2025
@holdex

holdex Bot commented Oct 8, 2025

Copy link
Copy Markdown

Time Submission Status

Member Status Time Action Last Update
MicBun ✅ Submitted 4h 30min Update time Oct 8, 2025, 3:02 AM

@holdex

holdex Bot commented Oct 8, 2025

Copy link
Copy Markdown

Bug Report Checklist

Status Commit Link Bug Author
✅ Submitted commit link @outerlook

@coderabbitai

coderabbitai Bot commented Oct 8, 2025

Copy link
Copy Markdown

Walkthrough

Updates the publish-node-image GitHub Actions workflow to treat the tag_latest input as a boolean instead of a string, affecting TAG_LATEST evaluation for workflow_dispatch. Also bumps Go module dependencies for github.com/trufnetwork/kwil-db and its core submodule to newer pseudo-versions.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/publish-node-image.yaml
Adjusts TAG_LATEST expression: replaces inputs.tag_latest == 'true' with direct boolean inputs.tag_latest, preserving OR with github.event_name == 'release'.
Dependencies
go.mod
Updates dependencies: github.com/trufnetwork/kwil-db to v0.10.3-0.20251007160956-022e6739f56d and github.com/trufnetwork/kwil-db/core to v0.4.3-0.20251007160956-022e6739f56d.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Developer
  participant GH as GitHub Actions
  participant WF as publish-node-image
  participant Reg as Container Registry

  Dev->>GH: Trigger workflow (workflow_dispatch with inputs.tag_latest) or Release event
  GH->>WF: Start job
  Note over WF: Compute TAG_LATEST = (inputs.tag_latest) OR (event_name == "release")
  WF->>WF: Build image
  alt TAG_LATEST true
    WF->>Reg: Push image with "latest" tag
  else TAG_LATEST false
    WF->>Reg: Push image without "latest" tag
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • outerlook

Poem

Hop hop hooray, a tag sets sail,
No quotes to fail the “latest” trail.
Gophers hum with modules new,
Pipelines churn a cleaner brew.
Carrots raised to builds that pass—
Latest lands, at last at last! 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes Check ⚠️ Warning In addition to the workflow fix, the PR includes updates to Go module versions in go.mod that are unrelated to the latest tagging issue. Please remove or isolate the dependency version bumps in a separate PR so that this change set focuses solely on the workflow fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary change—ensuring the node image is published with a latest tag—without extraneous detail or ambiguity.
Linked Issues Check ✅ Passed The PR modifies the GitHub Actions workflow to treat the tag_latest input as a boolean, directly addressing the issue where images were not tagged as latest when requested (#1193).
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fixPublishNode

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a97049e and 4575155.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • .github/workflows/publish-node-image.yaml (1 hunks)
  • go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build and Push
  • GitHub Check: lint
  • GitHub Check: acceptance-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MicBun

MicBun commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

@pr-time-tracker bug commit e62eb37 && bug author @outerlook

@MicBun

MicBun commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Merge immediately to reflect changes

@MicBun
MicBun merged commit df5fc14 into main Oct 8, 2025
8 checks passed
@MicBun
MicBun deleted the fixPublishNode branch October 8, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix fixing something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Publish Node Image GitHub Action did not tag image as latest

1 participant