Skip to content

creator-anim-fix #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Himanshu-Singh-Chauhan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

creator-anim-fix #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/vs/workbench/browser/parts/overlay/creatorView/creatorOverlayPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ export class CreatorOverlayPart extends Part {

// Wait briefly for a response + send another ping if it was lost
for (let i = 0; i < 100; i++) {
if (messageReceived) break;
if (messageReceived) {break;}
this.webviewElement.postMessage({ messageType: "ping" });
await new Promise((resolve) => setTimeout(resolve, 5));
}
Expand Down Expand Up @@ -882,6 +882,9 @@ export class CreatorOverlayPart extends Part {
const topOfBodyElement = this.getTopOfBodyElement();
const blurryElement = this.getBlurOverlayElement();

// Ensure transition is set
topOfBodyElement.style.transition = "height 500ms cubic-bezier(0.4, 0, 0.2, 1)";

// Set initial height based on current state
const currentHeight = topOfBodyElement.style.height;
topOfBodyElement.style.height = currentHeight || "0";
Expand All @@ -893,6 +896,11 @@ export class CreatorOverlayPart extends Part {
Object.assign(topOfBodyElement.style, stateConfig.topOfBody);
Object.assign(blurryElement.style, stateConfig.blurElement);

// Apply webview container styles if they exist
if (stateConfig.webview && this.overlayContainer) {
Object.assign(this.overlayContainer.style, stateConfig.webview);
}

// Update the enter creator button if it exists
const enterCreatorButton = document.querySelector(
ENTER_CREATOR_MODE_BTN_IDENTIFIER,
Expand Down