test(async): QA harness for async tag loading via the stub queue - #76
Open
paragmore wants to merge 1 commit into
Open
test(async): QA harness for async tag loading via the stub queue#76paragmore wants to merge 1 commit into
paragmore wants to merge 1 commit into
Conversation
|
paragmore
added a commit
that referenced
this pull request
Sep 7, 2026
…e repo logger Review feedback on #76: the replay merge let the data-question-id captured by the stub overwrite an explicitly passed options.questionId, inverting direct-construction precedence. Swap the spread order so the captured attribute only fills in when the option is absent, and route the malformed-entry diagnostic through createLogger like the rest of src/. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Kjq1CG5RwFMpeucoPJWML
Redskull-127
approved these changes
Sep 7, 2026
…t's stub The tag source moved to surface_forms (packages/surface-scripts, SURF-1936); the async stub-queue drain ships from there (surface_forms#5844) and reaches this repo through the publish workflow. This keeps the manual QA harness here with the rest of test/: async-stub.html loads the tag async with the install snippet's stub, constructs slideover/popup/inline/input-trigger embeds (plus prefillData and an early SurfaceSetConsent) before the tag arrives, and covers slow-tag (?tagDelay=<ms>) and blocked-tag (?noTag=1) scenarios with a live status panel. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Kjq1CG5RwFMpeucoPJWML
paragmore
force-pushed
the
feat/async-stub-queue
branch
from
September 7, 2026 12:16
8dc28f7 to
aac4a17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked after the SURF-1936 move
The tag source now lives in surface_forms (
packages/surface-scripts) and publishes to this repo. The stub-queue drain originally in this PR moved to trysurface/surface_forms#5844 (snippets: surface_forms#5841); this PR now carries only the manual QA harness, which belongs here with the rest oftest/.What
test/async-stub.html— loads the tag async with the install snippet's stub and constructs every embed before the tag arrives:prefillData) + inline + email input-trigger embeds, plus an earlySurfaceSetConsentcall?tagDelay=<ms>injects the tag late (fast site / slow tag),?noTag=1never injects it (page must stay functional)event-monitor.js's sent-events wrapper via the store-setter trap (same asdirect-iframe.html) so counters work with a late-loading tagNote
The harness exercises the drain, so it goes green once surface_forms#5844 merges and the publish workflow updates
surface_tag.jshere. Verified locally against a build containing the drain: queue drains, all embeds initialize, 4 iframes preload, prefill reaches the store, kept stub references open the real forms,?noTag=1stays error-free.🤖 Generated with Claude Code
https://claude.ai/code/session_013Kjq1CG5RwFMpeucoPJWML