fix RP2040 LED supplier polarity - #98
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
marked this pull request as ready for review
August 18, 2026 06:36
Co-authored-by: MustafaMulla29 <97171641+MustafaMulla29@users.noreply.github.com>
imrishabh18
requested changes
Aug 18, 2026
imrishabh18
left a comment
imrishabh18
left a comment
Member
There was a problem hiding this comment.
Not the right place to fix, the fix needs to be made upstream. So, on import of part numbers we don't face this issue anymore
…polarity # Conflicts: # examples/MicrocontrollerRP2040WithUsbC/__snapshots__/MicrocontrollerRP2040WithUsbC.circuit-pcb.snap.svg # lib/Microcontroller_RP2040/__snapshots__/Microcontroller_RP2040.circuit-pcb.snap.svg
Contributor
Author
|
@imrishabh18 the issue is already fixed, reimported the file |
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XL_1608SURC_06pin 1 to cathode/negative and pin 2 to anode/positiveC965799Root cause
The imported XINGLIGHT LED retained tscircuit's generic LED numbering (
pin1 = anode) while its supplier part defines pin 1 as cathode. The footprint previously compensated by swapping only its port hints, leaving the logical source pinout inconsistent with supplier metadata. Correcting the logical pinout also swapped the schematic endpoints, so the existing symbol rotations had to be turned 180 degrees to preserve the intended visual routing.Impact
Supplier-aware validation no longer reports a polarity mismatch for
D1andD_PWR, and the schematic keeps the cleanresistor -> LED -> GNDpresentation without changing PCB placement or electrical connectivity.Validation
bun test tests/test.test.tsx— 18 passedbun run buildbunx tsci snapshot lib/Microcontroller_RP2040/Microcontroller_RP2040.circuit.tsx --3d— all snapshots match