Conversation
Collaborator
|
In many environments, redirecting to "/" is wrong -- the application is deployed in a sub-path. It's certainly possible that your patch won't break those apps, but I'd like to be sure before applying your patch. |
gabriprat
pushed a commit
to gabriprat/hobo
that referenced
this pull request
Mar 20, 2016
Fix Stringify error with Chrome and Push State requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I found a problem when using hobo with capybara. in dev_controller.rb. When redirecting to "" (home_page has this value by default) capybara 'forgets' the session. Do you know if redirect to "" is really allowed? Maybe the home_page should have a real value instead of "". Think this would solve the problem also.