Retire Share Card exports and keep Copy diagram only - #234
Open
sunsunsun-java wants to merge 9 commits into
Open
sunsunsun-java wants to merge 9 commits into
sunsunsun-java wants to merge 9 commits into
Conversation
The fixed 1200x630 physical canvas was upscaled on Retina displays. Preserve the logical card layout while rendering a 2400x1260 PNG, scale the SVG source to its final physical draw size, and keep download and clipboard receipts truthful. Rebuild generated artifacts against upstream v2.16.0.
|
Warning Review limit reachedNext included review available in 38 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (21)
📒 Files selected for processing (64)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and value
The fixed 1200×630 Share Card path forced dense diagrams into a bad tradeoff: blurry raster output, unreadably small labels, or topology simplification that omitted modules readers expected to see. This PR implements the final decision in #229: retire the separate Share Card product surface and keep one complete, high-resolution Copy diagram action.
Closes #229.
Scope
v2.17.0-dev.0and synchronized package, Skill, documentation, generated artifacts, and ZIP bytes.Stability impact
Tests run
node --test test/copy-diagram-export.test.mjs test/architecture-delta.test.mjs— 22 passed, 0 failed.npm run test:webm— Architecture Delta export regression passed; Copy diagram passed for Architecture, Workflow, Sequence, Dataflow, and Lifecycle; site integration 6 passed, 0 failed, 1 opt-in Chrome test skipped.npm test— 995 tests: 968 passed, 0 failed, 27 environment skips.env ARCHIFY_MCO_REPO_ROOT=<mco@9f1a1cf> node --test test/real-repository-proof.test.mjs— 3 passed, including byte-for-byte reproduction of both checked-in MCO artifacts.node archify/bin/archify.mjs visual-check generated/maka-regenerated.workflow.html --json— pass; 4/4 containment viewports, 4/4 screenshots, minimum projected node text 7.13px at 1440×900.npm run check:release-identity—2.17.0-dev.0identity consistent.git diff --check— clean.Visual evidence
Visual review: passed.
The PR file diff provides the before/after comparison. The final captures remain contained, legible, and show the complete authored topology.
Generated artifacts
Regenerated from the final source:
archify.ziparchify/examples/dataflow-product-analytics.htmlarchify/examples/lifecycle-agent-run.htmlarchify/examples/sequence-cache-miss-request.htmlarchify/examples/web-app-rendered.htmlarchify/examples/workflow-agent-tool-call-rendered.htmldocs/assets/archify-live-proof.gifdocs/assets/archify-live-proof.jsondocs/cases/mco-runtime.architecture.htmldocs/gallery.htmldocs/gallery/manifest.jsondocs/gallery/artifacts/agent-run.lifecycle.htmldocs/gallery/artifacts/agent-tool-call.workflow.htmldocs/gallery/artifacts/async-job-roundtrip.sequence.htmldocs/gallery/artifacts/cache-miss.sequence.htmldocs/gallery/artifacts/deployment-release.lifecycle.htmldocs/gallery/artifacts/event-stream.dataflow.htmldocs/gallery/artifacts/incident-response.workflow.htmldocs/gallery/artifacts/product-analytics.dataflow.htmldocs/gallery/artifacts/production-deployment.architecture.htmldocs/gallery/artifacts/release-delivery.workflow.htmldocs/gallery/artifacts/web-app.architecture.htmldocs/guide.htmldocs/index.htmldocs/start.htmlexamples/archify-repo-grid.htmlexamples/archify-repo.htmlexamples/checkout-platform-delta.htmlexamples/checkout-platform-delta.receipt.jsonexamples/dataflow-product-analytics.htmlexamples/lifecycle-agent-run.htmlexamples/maka-architecture.htmlexamples/rag-pipeline.htmlexamples/sequence-cache-miss-request.htmlexamples/web-app-rendered.htmlexamples/web-app.htmlexamples/workflow-agent-tool-call-rendered.htmlexperiments/mco-showcase/mco-runtime.htmlgenerated/maka-regenerated.workflow.htmlgenerated/maka-regenerated.workflow.visual-check.1440x900.dark.pnggenerated/maka-regenerated.workflow.visual-check.1440x900.light.pnggenerated/maka-regenerated.workflow.visual-check.2048x1320.dark.pnggenerated/maka-regenerated.workflow.visual-check.2048x1320.light.pnggenerated/maka-regenerated.workflow.visual-check.jsonRemoved obsolete dedicated Share Card assets:
docs/assets/archify-menu.pngdocs/assets/archify-route-share-card.pngdocs/assets/mco-runtime-reach-share-card.pngdocs/assets/mco-runtime-share-card.pngChecklist
npm testinarchify/.