test: integrate Windows fixture portability fixes - #442
Merged
Merged
Conversation
…dows-checkout-tests
|
Warning Review limit reachedNext included review available in 31 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and value
Four existing regression fixtures assume POSIX path, signal, or mode behavior and fail before validating the intended contract on Windows. This consolidates #318, #319, #320, and #349 while preserving their original commits and authorship.
Changes and impact
Use a real empty Git config/attributes file, pass the migration preload as a file URL, invoke the preview shutdown handler through a Windows-only IPC relay, and verify staging modes from the Git index with POSIX filesystem assertions retained. Production code and packaged artifacts are unchanged. The relay tests graceful-handler behavior, not native Windows signal delivery.
Add a small Windows CI job that runs the six affected cases against the integrated head, and include it in the Pages dependency gate. Existing Linux full-suite coverage remains.
Validation
Integrated on dev
bfe6400. Local macOS, official Node22.23.2: checkout/migration/staging suites 39 passed, zero failures/skips; the exact Windows-job selection 6 passed, zero failures/skips; release/package CI contracts 21 passed, zero failures,2 existing conditional skips.actionlintandgit diff --checkpass. The new Windows job and full remote CI are pending; local results are not Windows acceptance. Author-provided historical Windows evidence remains in the original PRs.No archive regeneration: only tests and CI changed. Integration targets dev; main promotion requires separate actual-use acceptance.