Skip to content

Remove pkg/errors dependency - #408

Draft
AndrewRPorter wants to merge 1 commit into
twitchtv:mainfrom
AndrewRPorter:remove-pkg-errors
Draft

Remove pkg/errors dependency#408
AndrewRPorter wants to merge 1 commit into
twitchtv:mainfrom
AndrewRPorter:remove-pkg-errors

Conversation

@AndrewRPorter

Copy link
Copy Markdown

Summary

  • replace first-party github.com/pkg/errors usage with standard-library errors and fmt.Errorf wrapping
  • update error-chain tests and generated Twirp compatibility comments to use errors.Is/errors.As
  • remove the dependency from dep manifests and delete its vendored package

Testing

  • go test github.com/twitchtv/twirp github.com/twitchtv/twirp/internal/descriptors github.com/twitchtv/twirp/internal/gen/typemap github.com/twitchtv/twirp/protoc-gen-twirp github.com/twitchtv/twirp/clientcompat
  • go test -vet=off github.com/twitchtv/twirp/internal/twirptest

internal/twirptest uses -vet=off because the current Go toolchain reports pre-existing formatting diagnostics in unrelated test lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant