Repository navigation
Revert "remove gogo proto (#16)" - #18
Merged
Merged
Conversation
This reverts commit 9376506.
xytan0056
marked this pull request as ready for review
February 12, 2026 22:42
yushan8
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9376506. It breaks API due to incompatiblity of yarpc and grpc
Why?
controller is coupled with YARPC, when streaming
GraphReader.Read()the message must be YARPC, not gRPC. because when YARPC tries to serialize the request, it uses gogo protobuf's reflection which expects specific struct tags that google protobuf doesn't generate.reverting for now, a better approach is refactoring another layer that streams
<-chan *pb.GetTargetGraphResponseto yarpc/grpc/http transport layersTest Plan
Issue