Repository navigation
fix changed targets streaming - #19
Merged
Merged
Conversation
xytan0056
marked this pull request as ready for review
February 17, 2026 23:16
xytan0056
commented
Feb 17, 2026
| } | ||
| chunks = append(chunks, chunk) | ||
| } | ||
| graph, err := graphReader.Read() |
Contributor
Author
There was a problem hiding this comment.
graphreader only reads one chunk
xytan0056
commented
Feb 17, 2026
| for range jobs { | ||
| select { | ||
| case res := <-results: | ||
| if res.graph != nil { |
Contributor
Author
There was a problem hiding this comment.
at this point, the graphreader is done or eof, so we should makr jobs[res.order].completed = true and update jobs[res.order].err accordingly
yushan8
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix streaming bug in
GetChangedTargetswhere only the first chunk was read from storage, causing incomplete target graph comparisons.get-changed-targets call now returns returns nothing and nil metadata
Why?
The
GetChangedTargetsfunction was only reading the first chunk from storage, but target graphs are serialized as multiple delimited messages (chunks + metadata). Currently missing metadata entirely. We should do whatGetTargetGraphdoes here -- for loop read until eofWhat?
Test Plan
Issue