Repository navigation
Conversation
xytan0056
marked this pull request as ready for review
February 26, 2026 01:25
xytan0056
commented
Feb 26, 2026
| ) | ||
|
|
||
| const ( | ||
| lockFileName = ".tango.lease.lock" |
Contributor
Author
There was a problem hiding this comment.
not needed anymore. We only need a mutex per repo, and workers concurrency is managed by avail chan
xytan0056
commented
Feb 26, 2026
|
|
||
| const ( | ||
| lockFileName = ".tango.lease.lock" | ||
| lockTimeout = 5 * time.Minute |
Contributor
Author
There was a problem hiding this comment.
instead of timeout, we just wait until a workspace is available. If client doesn't wanna wait, it can just cancel the request
xytan0056
commented
Feb 26, 2026
| lockTimeout = 5 * time.Minute | ||
| lockRetryDelay = 15 * time.Second | ||
| ) | ||
| const defaultPoolSize = 3 |
Contributor
Author
There was a problem hiding this comment.
will do next diff, make it configurable
yushan8
reviewed
Feb 26, 2026
|
|
||
| // Release releases the workspace lock. | ||
| // Release is a no-op for the base workspace; pooled workspaces override this. | ||
| func (w *workspace) Release() error { |
Contributor
There was a problem hiding this comment.
Looks like we don't need this function anymore?
Contributor
Author
There was a problem hiding this comment.
good cactch!
It's actually still needed when orchestrator calls Release when bazel query and graphing is done. It's just overridden by pooledWorkspce
will do next diff
yushan8
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently repo manager only manages one workspace off of one clone. But we can manage multiple workspaces
Why?
Multi workspaces clones with "--local" , greatly speeds up the process and increase storage efficiency.
What?
poolFor()Test Plan
CI unit test
local test
Issue