Skip to content

configurable worker pool and release callback - #23

Merged
xytan0056 merged 2 commits into
mainfrom
gitclean
Feb 26, 2026
Merged

xytan0056 merged 2 commits into
mainfrom
gitclean

Conversation

@xytan0056

Copy link
Copy Markdown
Contributor

Configurable workspace pool and release() cleanup

Why?

orchestrator calls ws.Release(), but workspace doesn't know about repo_manager stuff. So either we make orchestrator call repomanager to release by passing WS info, which is too much hassle. A better approach to add callback to WS, let it invoke repo manager's release logic.

also make worker pool size configurable with default to 1

What?

  • workspace_pool_size added to RepositoryConfig — validated > 0 at startup, defaults to 1 if unset programmatically.
  • workspace now takes an OnRelease callback to return itself to the pool, eliminating an unnecessary type.

Test Plan

CI unit test
local manual tests

Issue

@xytan0056
xytan0056 marked this pull request as ready for review February 26, 2026 02:22
@xytan0056
xytan0056 requested review from a team as code owners February 26, 2026 02:22
@xytan0056
xytan0056 merged commit a29e7ec into main Feb 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants