Repository navigation
Conversation
xytan0056
marked this pull request as ready for review
February 26, 2026 02:29
xytan0056
commented
Feb 26, 2026
| if err := w.git.Reset(ctx); err != nil { | ||
| return fmt.Errorf("git reset --hard: %w", err) | ||
| } | ||
| if err := w.git.Clean(ctx); err != nil { |
Contributor
Author
There was a problem hiding this comment.
this potentially can be slow to delete, if there are folders like "bazel-out" or "pkg/mod/" stuff. But i see current TA does this too. And it's necessary if request is cancel in the middle of git checkout, repo is in a dirty state. We can try this out.
Another way is to delete the whole WS and ask repo manager to re-clone with --local. We can do this if clean -fdx is too slow
wdyt? @yushan8
Contributor
There was a problem hiding this comment.
I think it'll helpful to benchmark the performance after and see which one is faster with reseting the workspace
yushan8
approved these changes
Feb 26, 2026
| if err := w.git.Reset(ctx); err != nil { | ||
| return fmt.Errorf("git reset --hard: %w", err) | ||
| } | ||
| if err := w.git.Clean(ctx); err != nil { |
Contributor
There was a problem hiding this comment.
I think it'll helpful to benchmark the performance after and see which one is faster with reseting the workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before checkout to requested sha , clean up the ws just in case there are leftever files or corruptions
Test Plan
unit test
local tested
Issue