Repository navigation
Implement NameIDMapper as a module to use for translating names to IDs - #5
Merged
Merged
Conversation
Update Update test Update
yushan8
force-pushed
the
diff-between-graph
branch
from
January 29, 2026 22:55
5d1aa01 to
5b99f71
Compare
yushan8
changed the title
yushan8
marked this pull request as ready for review
January 29, 2026 22:58
xytan0056
reviewed
Jan 30, 2026
Contributor
There was a problem hiding this comment.
can we have this translation function in another file? To avoid conflicts when we sync Uber targethasher to this file,
Contributor
Author
There was a problem hiding this comment.
Good point I'll move it
xytan0056
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translation to OptimizedTargets from name -> id is common functionality. This module is needed for comparing target graphs and converting Results ->
OptimizedTargetsto store the target graph. A separate moduleNameIDMapperis needed to assign names to ID numbers.Tested with unit test