Skip to content

[tango] Check if attributes and dependencies differ and mark the ChangeType as direct - #9

Merged
yushan8 merged 2 commits into
mainfrom
attr-change-direct
Feb 4, 2026
Merged

[tango] Check if attributes and dependencies differ and mark the ChangeType as direct#9
yushan8 merged 2 commits into
mainfrom
attr-change-direct

Conversation

@yushan8

@yushan8 yushan8 commented Feb 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why?

Check if attributes and dependencies differ and mark the ChangeType as direct. This matches the internal behavior.

What?

  1. If the target has a dependency that is a source file, mark the change type as DIRECT. This is faster than going through all the dependencies of the targets and checking for dependency changes.
  2. If the dependencies differ, mark the change type as DIRECT.
  3. If any of the attributes or their values differ, mark the change type as DIRECT.

Test Plan

unit test

@yushan8 yushan8 changed the title [tango] Add direct change for changes in dependencies and attributes [tango] Check if attributes and dependencies were changed and mark the target as direct Feb 4, 2026
@yushan8 yushan8 changed the title [tango] Check if attributes and dependencies were changed and mark the target as direct [tango] Check if attributes and dependencies differ and mark the ChangeType as direct Feb 4, 2026
@yushan8
yushan8 marked this pull request as ready for review February 4, 2026 21:52
@yushan8
yushan8 requested review from a team as code owners February 4, 2026 21:52
xytan0056
xytan0056 reviewed Feb 4, 2026
View reviewed changes
Comment thread core/controller/getchangedtargets.go
Comment thread core/controller/getchangedtargets.go
Comment thread core/controller/getchangedtargets.go
@yushan8
[tango] Add direct change for changes in dependencies and attributes
9353757 
Update

Update

Update

validate target names

Add validation
@yushan8
yushan8 force-pushed the attr-change-direct branch from 4f66f4f to 9353757 Compare February 4, 2026 23:15
@yushan8
yushan8 merged commit 4f246dc into main Feb 4, 2026
1 check passed
@yushan8
yushan8 deleted the attr-change-direct branch March 16, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xytan0056 xytan0056 xytan0056 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yushan8 @xytan0056