Repository navigation
Share search and scan utilities across cache and index types - #87
Merged
Merged
Conversation
Add utils.search.SearchRequests for k and minSimilarity checks and result limits, and utils.scan.ComparatorRowScan for parallel full-scan scoring. Cache and Index entry points delegate to them so scan, matrix, and inverted implementations share one path.
drametwally
force-pushed
the
utils-shared-search-scan
branch
from
October 1, 2026 04:09
160f710 to
265bba2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils.search.SearchRequestsfor k/minSimilarity validation, namespace result caps, and empty-search short-circuiting used by every cache and index type.utils.scan.ComparatorRowScanfor comparator scoring duringParallelRowScan(scan cache, scan index, inverted term cache brute-force path).CacheandIndexpublic search methods; concrete structures implementsearchNearestNeighbors/searchSimilarRowNums(indexes) or locked hooks with resolved limits (caches).Stacks on #86 (
utils.inverted); merge #86 first or merge this branch as one unit.Test plan
bazel test //:test_main