Preservica fetcher and mapper - #1333
Open
barbarahui wants to merge 10 commits into
Open
Conversation
barbarahui
force-pushed
the
preservica
branch
3 times, most recently
from
July 9, 2026 21:33
084786b to
0fe2c4e
Compare
barbarahui
changed the title
barbarahui
force-pushed
the
preservica
branch
3 times, most recently
from
July 10, 2026 23:23
ba8bef6 to
5b039b4
Compare
Open
barbarahui
force-pushed
the
preservica
branch
2 times, most recently
from
July 14, 2026 18:35
fc6380e to
84137dc
Compare
barbarahui
marked this pull request as ready for review
July 15, 2026 16:32
barbarahui
marked this pull request as draft
July 15, 2026 16:34
barbarahui
marked this pull request as ready for review
July 15, 2026 22:20
barbarahui
force-pushed
the
preservica
branch
3 times, most recently
from
July 15, 2026 23:18
25e1664 to
92e9e57
Compare
Closed
bibliotechy
reviewed
Jul 24, 2026
bibliotechy
left a comment
bibliotechy
left a comment
Contributor
There was a problem hiding this comment.
Looks good, one comment. Thanks for fighting with a weird system :)
|
|
||
| fetched_page = http_resp.json() | ||
| self.num_fetched += len(fetched_page.get("value", {}).get("metadata", [])) | ||
| if self.num_fetched >= fetched_page.get("value", {}).get("totalHits"): |
Contributor
There was a problem hiding this comment.
There is a risk that if totalHits is not in the dictionary then this will error as it will try to compare an int to None. Might be worth explicitly try / except for that condition just to avoid a future debug dive on what might jsut be a transitory issue.
bibliotechy
previously approved these changes
Jul 24, 2026
amywieliczka
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
I added the
stateLocatedInmapping since that existed in the legacy mapper, even though it looks like we didn't implement the related enrichment in Rikolti. I noticed that we've ported over this mapping for a few other collections too.